Repository navigation
[AMD] build(docker): bump ROCm torch_memory_saver to 118b09b - #4318
Merged
guapisolo merged 1 commit intoOct 22, 2026
Merged
Conversation
Pin the ROCm image to the same torch_memory_saver commit as the CUDA images, which synchronizes devices before pause() backs up or unmaps memory. Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>
guapisolo
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ROCm image pins torch_memory_saver to 06caa534. The CUDA images now pin 118b09b, which synchronizes devices before
pause()backs up or unmaps memory, so the ROCm image can still back up or unmap memory while work is in flight on another stream.Change
Pin the ROCm image to the same torch_memory_saver commit, 118b09b.
Validation
Tested on MI355X with the current ROCm 10 nightly image: 118b09b builds, its new pause-sync tests pass (10/10), and the other tests give the same results as the old pin.
Co-author-with: @JessicaJiang-123